[PATCH] D72580: [mlir][Linalg] Update ReshapeOp::build to be more idiomatic

[Alex Zinenko via Phabricator via llvm-commits]

ftynse requested changes to this revision.
ftynse added a comment.
This revision now requires changes to proceed.

The part that drops symbols needs documentation, including on the ::build to say that symbols will be dropped, and tests. I'm not confident that creating an AffineMap with 0 symbols from a list of expressions that might use symbols is correct.



================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:469
+static void getMaxDimIndex(ArrayRef<ArrayRef<AffineExpr>> exprArrays,
+                           unsigned &pos) {
+  for (auto exprs : exprArrays) {
----------------
Could this just return `pos`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72580/new/

https://reviews.llvm.org/D72580