[PATCH] D72481: [mlir][EDSC] Refactor dependencies involving EDSCs.
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 12 20:30:29 PST 2020
nicolasvasilache marked an inline comment as done.
nicolasvasilache added a comment.
Herald added subscribers: liufengdb, aartbik.
Yes it is NFC, just marked it as such.
Fixed the formatting issue, thanks!
================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:53-54
+ fun();
+ exit();
+ return ValueHandle::null();
+}
----------------
jpienaar wrote:
> [for follow up] I read exit and was thinking std::exit here. Could we do exitBlock maybe? That way its clearer locally.
Ack, will do as a followup.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72481/new/
https://reviews.llvm.org/D72481
More information about the llvm-commits
mailing list