[PATCH] D72487: [AMDGPU] Fix bundle scheduling
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 12:35:40 PST 2020
rampitec added a comment.
In D72487#1814764 <https://reviews.llvm.org/D72487#1814764>, @rampitec wrote:
> In D72487#1813828 <https://reviews.llvm.org/D72487#1813828>, @foad wrote:
>
> > Instead how about doing this and implementing it in `adjustSchedDependency` for AMDGPU?
> >
> > diff --git a/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp b/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
> > index 96a1f86c3e0..ef5926e4f8f 100644
> > --- a/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
> > +++ b/llvm/lib/CodeGen/ScheduleDAGInstrs.cpp
> > @@ -269,9 +269,9 @@ void ScheduleDAGInstrs::addPhysRegDataDeps(SUnit *SU, unsigned OperIdx) {
> > if (!ImplicitPseudoDef && !ImplicitPseudoUse) {
> > Dep.setLatency(SchedModel.computeOperandLatency(SU->getInstr(), OperIdx,
> > RegUse, UseOp));
> > - ST.adjustSchedDependency(SU, UseSU, Dep);
> > } else
> > Dep.setLatency(0);
> > + ST.adjustSchedDependency(SU, UseSU, Dep);
> >
> > UseSU->addPred(Dep);
> > }
> >
>
>
> Looks like this patch would break some internal logic inside Hexagon's adjustSchedDependency()...
D72535 <https://reviews.llvm.org/D72535>
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72487/new/
https://reviews.llvm.org/D72487
More information about the llvm-commits
mailing list