[PATCH] D72564: [NFC] Fix compilation of CrashRecoveryContext.cpp on mingw
Markus Böck via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jan 11 16:24:52 PST 2020
zero9178 created this revision.
zero9178 added reviewers: aganea, rnk, hans.
Herald added subscribers: llvm-commits, mstorsjo, hiraditya.
Herald added a project: LLVM.
The method HandleCrash takes a uintptr as it's second argument. Trying to pass type PEXCEPTION_POINTERS requires a reinterpret_cast.
Would need someone to commit this for me as well
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D72564
Files:
llvm/lib/Support/CrashRecoveryContext.cpp
Index: llvm/lib/Support/CrashRecoveryContext.cpp
===================================================================
--- llvm/lib/Support/CrashRecoveryContext.cpp
+++ llvm/lib/Support/CrashRecoveryContext.cpp
@@ -266,7 +266,8 @@
// Handle the crash
const_cast<CrashRecoveryContextImpl *>(CRCI)->HandleCrash(
- (int)ExceptionInfo->ExceptionRecord->ExceptionCode, ExceptionInfo);
+ (int)ExceptionInfo->ExceptionRecord->ExceptionCode,
+ reinterpret_cast<uintptr_t>(ExceptionInfo));
// Note that we don't actually get here because HandleCrash calls
// longjmp, which means the HandleCrash function never returns.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72564.237523.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200112/da4e9394/attachment.bin>
More information about the llvm-commits
mailing list