[PATCH] D72398: [AArch64][SVE] Add ptest intrinsics

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 18:19:01 PST 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor request.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10829
+  // Convert CC to integer based on requested condition.
+  // NOTE: Cond is inverted to promote CSEL's removal when it feeds a compare.
+  SDValue CC = DAG.getConstant(getInvertedCondCode(Cond), DL, MVT::i32);
----------------
Could you add a testcase where the ptest feeds a compare/branch, to show that combination works as expected?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72398/new/

https://reviews.llvm.org/D72398





More information about the llvm-commits mailing list