[PATCH] D72519: [LoopInfo] Support multi edge in getLoopLatch()

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 17:38:51 PST 2020


efriedma added a comment.

My concern with this is that there there might be some places where we're assuming the backedge of a loop latch is exactly one edge, and you might not have found them.  There are a lot of places that call getLoopLatch or isLoopSimplifyForm, we don't really have much regression test coverage for this sort of construct, and the C/C++ tests most people run probably have few switches like this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72519/new/

https://reviews.llvm.org/D72519





More information about the llvm-commits mailing list