[PATCH] D72547: [llvm] Make new pass manager's OptimizationLevel a class

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 16:53:13 PST 2020


mtrofin added a comment.

Another example where there is a discrepancy with the old pass manager: in the old pass manager (PassManagerBuilder::addFunctionSimplificationPasses):

  if (OptLevel > 1) {
      if (EnableGVNHoist)
        MPM.add(createGVNHoistPass());

(before this change, new pass manager):

  if (Level > O1) {
     if (EnableGVNHoist)
       FPM.addPass(GVNHoistPass());

Which really means "O2 <https://reviews.llvm.org/owners/package/2/>-3, and Os and Oz". I currently left it backwards compatible - since I'm not sure the added support for gvn hoisting for Os/z was intentional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72547/new/

https://reviews.llvm.org/D72547





More information about the llvm-commits mailing list