[PATCH] D71733: [NFC][InlineCost] Factor cost modeling out of CallAnalyzer traversal.
Easwaran Raman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 16:27:13 PST 2020
eraman added a comment.
LGTM
================
Comment at: llvm/lib/Analysis/InlineCost.cpp:241
+ /// isAllocaDerivedArg to function correctly.
+ DenseSet<AllocaInst *> EnabledSROAArgValues;
----------------
nit on naming: Perhaps use EnabledSROAAllocas ? Also, I feel the comment lines starting from We don't delete... is not required.
================
Comment at: llvm/lib/Analysis/InlineCost.cpp:2226
break;
- // Disallow inlining of @llvm.icall.branch.funnel because current
- // backend can't separate call targets from call arguments.
case llvm::Intrinsic::icall_branch_funnel:
+ // Disallow inlining of @llvm.icall.branch.funnel because current
----------------
Looks like unintended change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71733/new/
https://reviews.llvm.org/D71733
More information about the llvm-commits
mailing list