[PATCH] D72545: [mlir] Remove 'valuesToRemoveIfDead' from PatternRewriter API

[Diego Caballero via Phabricator via llvm-commits]

dcaballe created this revision.
Herald added subscribers: llvm-commits, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, burmako, jpienaar, rriddle, mehdi_amini.
Herald added a project: LLVM.
dcaballe added reviewers: rriddle, bondhugula.

Remove 'valuesToRemoveIfDead' from PatternRewriter API. The removal
functionality wasn't implemented and we decided [1] not to implement it in
favor of having more powerful DCE approaches.

[1] https://github.com/tensorflow/mlir/pull/212


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72545

Files:
  mlir/examples/toy/Ch3/mlir/ToyCombine.cpp
  mlir/examples/toy/Ch4/mlir/ToyCombine.cpp
  mlir/examples/toy/Ch5/mlir/ToyCombine.cpp
  mlir/examples/toy/Ch6/mlir/ToyCombine.cpp
  mlir/examples/toy/Ch7/mlir/ToyCombine.cpp
  mlir/include/mlir/IR/PatternMatch.h
  mlir/include/mlir/Transforms/DialectConversion.h
  mlir/lib/Dialect/QuantOps/Transforms/ConvertConst.cpp
  mlir/lib/Dialect/StandardOps/Ops.cpp
  mlir/lib/IR/PatternMatch.cpp
  mlir/lib/Transforms/DialectConversion.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72545.237450.patch
Type: text/x-patch
Size: 16230 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200110/46f80f77/attachment.bin>