[PATCH] D72522: [Hexagon] Add support for global dynamic relocs

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/hexagon-tls-gd.s:12
+# RUN: llvm-readobj -x .tdata %t.so | FileCheck -check-prefix=TDATA %s
+# RUN: llvm-readobj -r  %t.so | FileCheck -check-prefix=RELA %s
+
----------------
Add llvm-readobj -r %t to test %t does not have a relocation. 

GD->LD still applies, even if the code sequence does not change.


================
Comment at: lld/test/ELF/hexagon-tls-gd.s:22
+# CHECK-NEXT:     r0 = add(r1,##-0x10008) }
+                  r0 = add(r1, ##a at GDGOT)
+
----------------
Doesn't Hexagon need to call `__tls_get_addr`?


================
Comment at: lld/test/ELF/hexagon-tls-gd.s:34
+# GOT-SHARED: Hex dump of section '.got':
+# GOT-SHARED-NEXT: 0x0002024c 00000000 00000000
+
----------------
Since the address is insignificant, `0x{{[0-9a-f]+}}`


================
Comment at: lld/test/ELF/hexagon-tls-gd.s:41
+# RELA-NEXT:   0x2024C R_HEX_DTPMOD_32 a 0x0
+# RELA-NEXT:   0x20250 R_HEX_DTPREL_32 a 0x0
+
----------------
Check closing brace `}` as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72522/new/

https://reviews.llvm.org/D72522