[PATCH] D72538: [ThinLTO] Add additional ThinLTO pipeline testing with new PM

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 13:38:45 PST 2020


tejohnson created this revision.
tejohnson added a reviewer: wmi.
Herald added subscribers: jfb, dexonsmith, steven_wu, hiraditya, inglorion, mehdi_amini.
Herald added projects: clang, LLVM.

I've added some more extensive ThinLTO pipeline testing with the new PM,
motivated by the bug fixed in D72386 <https://reviews.llvm.org/D72386>.

I beefed up llvm/test/Other/new-pm-pgo.ll a little so that it tests
ThinLTO pre and post link with PGO, similar to the testing for the
default pipelines with PGO.

Added new pre and post link PGO tests for both instrumentation and
sample PGO that exhaustively test the pipelines at different
optimization levels via opt.

Added a clang test to exhaustively test the post link pipeline invoked for
distributed builds. I am currently only testing O2 <https://reviews.llvm.org/owners/package/2/> and O3 <https://reviews.llvm.org/owners/package/3/> since these
are the most important for performance.

It would be nice to add similar exhaustive testing for full LTO, and for
the old PM, but I don't have the bandwidth now and this is a start to
cover some of the situations that are not currently default and were
under tested.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72538

Files:
  clang/test/CodeGen/thinlto-distributed-newpm.ll
  llvm/test/Other/Inputs/new-pm-thinlto-prelink-pgo-defaults.proftext
  llvm/test/Other/Inputs/new-pm-thinlto-samplepgo-defaults.prof
  llvm/test/Other/new-pm-pgo.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72538.237425.patch
Type: text/x-patch
Size: 72379 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200110/048e5b51/attachment.bin>


More information about the llvm-commits mailing list