[PATCH] D72517: [lld/ELF] PR44498: Support input filename in double quote
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 13:38:44 PST 2020
MaskRay added a comment.
I think we should add logic to `StringMatcher` instead of `GlobPattern`.
================
Comment at: lld/test/ELF/linkerscript/filename-spec.s:33
-# RUN: echo "SECTIONS{.foo :{ %/t.dir/filename-spec2.o(.foo) %/t.dir/filename-spec1.o(.foo) }}" > %t5.script
+# RUN: echo "SECTIONS{.foo :{ \"%/t.dir/filename-spec2.o\"(.foo) \"%/t.dir/filename-spec1.o\"(.foo) }}" > %t5.script
# RUN: ld.lld -o %t5 --script %t5.script \
----------------
Un-quote this test so that we won't lose coverage for unquoted strings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72517/new/
https://reviews.llvm.org/D72517
More information about the llvm-commits
mailing list