[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

Fri Jan 10 13:31:24 PST 2020

ajpaverd added a comment.

In D65761#1811097 <https://reviews.llvm.org/D65761#1811097>, @hubert.reinterpretcast wrote:

> In D65761#1804302 <https://reviews.llvm.org/D65761#1804302>, @hubert.reinterpretcast wrote:
>
> > I have confirmed that the case I mentioned fails with rGd157a9b <https://reviews.llvm.org/rGd157a9bc8ba1085cc4808c6941412322a7fd884e>.
>
>
> @ajpaverd, is a fix forthcoming for the issue I mentioned with this patch?

The CFGuard library shouldn't be needed for targets other than ARM, AArch64, and X86, and it's only being built for these targets. However, it looks like `llvm-build` is also including it in the `LibraryDependencies.inc` file for other targets, such as PowerPC, which I think is causing this error. I'm not sure how to indicate that the library is only needed for a specified subset of targets. @rnk or @hans  any suggestions?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65761/new/

https://reviews.llvm.org/D65761