[PATCH] D72514: [mlir][ods] Support dialect specific content emission via hooks

Lei Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 11:56:02 PST 2020


antiagainst added a comment.

In D72514#1814809 <https://reviews.llvm.org/D72514#1814809>, @nicolasvasilache wrote:

> This majority of the code is about moving classes to includes to expose them to the outside world, the new portions are self-contained, LGTM.


Yup. Actually I splitted them into two commits: the first one purely for code moving; the second one contains the hook support. I'll land them as two separate commits for better Git history.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72514/new/

https://reviews.llvm.org/D72514





More information about the llvm-commits mailing list