[PATCH] D66426: [lld] Enable a watermark of loadable sections to be generated and placed in a note section

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Apologies for the late reply.

http://lists.llvm.org/pipermail/llvm-dev/2019-November/137108.html does not evoke many responses. I take the lack of responses on the RFC and questions from @JonChesterfield and @ruiu as people are still doubting whether this feature will be generic enough to benefit the community, rather than a feature used in a very specific scenario, which can be easily replaced by another tool. I have also asked some other folks but haven't receive positive reaction yet. I concur with what @ruiu said. I feel this just raises the bar of an arm race, which may not be necessary in the first place if the process can be improved (why can the build system modify contents after linking and before a binary manipulation tool like llvm-objcopy?).

I think this feature, as it stands, is not quite justified as a linker feature. Adding to llvm-objcopy is probably fine but I hope we can aim for something bigger. The statement "compliant with the system ABI" is pretty vague. Its defined meaning here is: "if we are byte identical, then we are ABI compliant." This is obviously too strong and does not reflect the real fact. If we want to make sure external symbols (part of ABI) do not change, we can use something like interface shared objects. Fedora is doing something more generic. https://fedoraproject.org/wiki/Toolchain/Watermark I wish if we want to add an LLVM watermark, we can make it more generally useful.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66426/new/

https://reviews.llvm.org/D66426