[PATCH] D72228: [MIPS][ELF] Use PC-relative relocations in .eh_frame when possible
Daniel Sanders via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 10:50:39 PST 2020
dsanders added a comment.
I see you've added me as a reviewer but I haven't worked on MIPS for a few years so I'm not really familiar with the current state of their linkers and binaries. AFAIK @atanasyan is still actively working on MIPS so hopefully he can take a look or bring in a colleague who can.
FWIW, this sounds like a good change and the code looks good to me but I think you should get another LGTM from someone more up to date on MIPS.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72228/new/
https://reviews.llvm.org/D72228
More information about the llvm-commits
mailing list