[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 10:33:04 PST 2020
MaskRay added inline comments.
================
Comment at: llvm/test/tools/llvm-ar/response.test:27
+
+# RUN: echo "rc %t.a blah\foo" > %t-rsp.txt
+# RUN: not llvm-ar --rsp-quoting=windows @%t-rsp.txt 2>&1 | \
----------------
Prefer single quotes. It does less translation. Shell quoting is difficult. With single quotes, a reader can think less what happens here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69665/new/
https://reviews.llvm.org/D69665
More information about the llvm-commits
mailing list