[PATCH] D72515: Add Targeted LiveDebugValues Tests That Exercise Specific Expected Behaviours

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_diamond_one_move.mir:17
+  ; CHECK-NOT:   DBG_VALUE $ebx, $noreg, !16, !DIExpression(), debug-location !17
+  ; CHECK-NOT:   DBG_VALUE $eax, $noreg, !16, !DIExpression(), debug-location !17
+
----------------
Have you considered running FileCheck with `-implicit-check-not=DBG_VALUE`? That might be less brittle (e.g. it'd survive small changes to how DBG_VALUE is printed out).


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_basic_loop.mir:5
+  ; Check that debug value intrinsics are propogated throughout a CFG with a
+  ; loop that doesn't move or clobber it's location.
+
----------------
nit, it's -> its


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb.mir:4
+
+  ; Check that debug value intrinsics are propogated throughout a CFG with a
+  ; loop that doesn't move or clobber it's location.
----------------
nit, propogate -> propagate


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb.mir:5
+  ; Check that debug value intrinsics are propogated throughout a CFG with a
+  ; loop that doesn't move or clobber it's location.
+
----------------
This one isn't a loop, it seems. Just a chain of jumps?


================
Comment at: llvm/test/DebugInfo/MIR/X86/livedebugvalues_bb_to_bb_clobbered.mir:10
+  ; CHECK-LABEL: bb.1.bb1:
+  ; CHECK:       DBG_VALUE $ebx, $noreg, !16, !DIExpression(), debug-location !17
+  ; CHECK-LABEL: bb.2.bb2:
----------------
Is the interesting thing here the undef DBG_VALUE? Could this be:
```
; CHECK-LABEL: bb.1.bb1:
; CHECK:       DBG_VALUE $ebx, $noreg, !16
; CHECK:       $ebx = MOV32ri 0
; CHECK:       DBG_VALUE $noreg, $noreg, !16
```
?

If so it might be another argument to have an implicit check-not for DBG_VALUE in these tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72515/new/

https://reviews.llvm.org/D72515