[PATCH] D72305: [TSan] The "thread_terminate" event is delivered on the terminating thread
Dan Liew via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 10:12:59 PST 2020
delcypher added inline comments.
================
Comment at: compiler-rt/lib/tsan/rtl/tsan_platform_mac.cpp:197
// We're using a libpthread API that notifies us about a newly created thread.
// The `thread == pthread_self()` check indicates this is actually a worker
// thread. If it's just a regular thread, this hook is called on the parent
----------------
Does this comment need updating? The comment and your change together imply that the `PTHREAD_INTROSPECTION_THREAD_TERMINATE` event only happens on GCD worker threads. Is that right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72305/new/
https://reviews.llvm.org/D72305
More information about the llvm-commits
mailing list