[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1981
+
+  cast<MCSymbolXCOFF>(Label)->setContainingCsect(TCEntry);
+  return TCEntry;
----------------
Other getSection... function do not set the containing csect. 
And I think for the design of the function, this extra convenient thing it does, did not reflect on anywhere (function name does not suggest it would do that). When developer see the call site only, they might actually want to find out why we do not set the containing csect (until they find it here). 
So I suggest to move it out for both consistency and the design. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347