[PATCH] D72470: [scudo][standalone] Fork support
Kostya Kortchinsky via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 10 09:53:13 PST 2020
cryptoad marked an inline comment as done.
cryptoad added a comment.
In D72470#1814446 <https://reviews.llvm.org/D72470#1814446>, @eugenis wrote:
> SCUDO_PREFIX(Mutex) can be acquired in the child process, and in the parent process, and is not held during fork. That's a potential deadlock.
> The condvar code reduces the window for it, but does not eliminate it completely.
> Why can't malloc_disable() simply directly call allocator.disable(), and the same in malloc_enable?
You are right. Everything still works with just disable/enable. I will change this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72470/new/
https://reviews.llvm.org/D72470
More information about the llvm-commits
mailing list