[PATCH] D72475: [WIP] Build assume from call

[Tyker via Phabricator via llvm-commits]

Tyker added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/AssumeBuilder.cpp:77
+  }
+};
+
----------------
jdoerfert wrote:
> Formatting: The methods should start with a lower case letter.
> 
> 
> Maybe add a TODO mentioning that we should look in the vicinity for other assumes we can merge the information with.
> Maybe add a TODO mentioning that we should look in the vicinity for other assumes we can merge the information with.
to do this the BuildAssumeFromInst will have to change and insert the assume. i don't know if it is preferable.


================
Comment at: llvm/lib/Transforms/Utils/AssumeBuilder.cpp:85
+  return Builder.Build();
+}
+
----------------
jdoerfert wrote:
> I'd just get the module from the instruction. `I->getModule()`
the module can't be const because of Intrinsic::getDeclaration requires a non-const Module.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72475/new/

https://reviews.llvm.org/D72475