[PATCH] D72337: [DebugInfo][Support] Replace DWARFDataExtractor size function

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 10 07:46:24 PST 2020


jhenderson added a comment.

In D72337#1814124 <https://reviews.llvm.org/D72337#1814124>, @dblaikie wrote:

> Ah, thanks for the context! Yeah, go ahead and commit it without a test case - the new implementation is strictly simpler/more obvious & I don't think the unit test really adds value/is likely to catch any regressions here.


Thanks. I didn't see your comment when I was doing the rebase, but I'll make sure to remove the extra unit test before landing it on Monday.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72337/new/

https://reviews.llvm.org/D72337





More information about the llvm-commits mailing list