[PATCH] D59780: Support Intel Control-flow Enforcement Technology

Fri Jan 10 03:22:40 PST 2020

xiangzhangllvm added inline comments.

================
Comment at: lld/test/ELF/x86-64-feature-cet.s:40
+# GOTPLT-NEXT: 203480 80232000 00000000 00000000 00000000
+# GOTPLT-NEXT: 203490 00000000 00000000 50132000 00000000
+# GOTPLT-NEXT: 2034a0 00000000 00000000
----------------
MaskRay wrote:
> xiangzhangllvm wrote:
> > lit test failed here, Here we mainly check is the first plt address is written correct in .got.plt
> > and we can really see the data (50132000)
> > 201350: f3 0f 1e fa                   endbr64       // First PLT
> > 
> > I see here (line 87) add indirect function check, do we need to deal with this special function in this patch?
> > or deal with it in another independent patch? 
> On RELA targets, .got.plt slots for IFUNC are not used. They can be kept zero. See D72474
> 
> Unfortunately pre-merge-bot does not recognize patch dependencies, so `x86-64-feature-cet.s` will fail.
So can we remove the GOTPLT check here let it 'skip' the bot check? because LLVM 10.0.0 will release on Jan 15, 2020. We can add back the GOTPLT check after the dependent patch merged.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59780/new/

https://reviews.llvm.org/D59780