[PATCH] D72157: [test][llvm-dwarfdump] Add extra test case for invalid MD5 form

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D72157#1813368 <https://reviews.llvm.org/D72157#1813368>, @dblaikie wrote:

> I guess these error messages could be more precise about what's invalid & why it's invalid. In this case I guess it's invalid because the DW_LNCT_MD5 has a form that contains only one byte, not large enough to encode a whole MD5 sum?


I agree with making the error message more precise, but that's probably a different change. It's invalid as you say due to the bad form (I think that's the only way it can be invalid).

> & this is to demonstrate that other things can still be parsed in spite of that failure?

Right. It goes with the follow-on change D72158 <https://reviews.llvm.org/D72158> that shows that parsing will continue after the failure. Following that change, there'll be two different cases to handle, which result in different sets of warnings. Note that in D72158 <https://reviews.llvm.org/D72158> one of the two MD5 invalid hashes results in a "size doesn't match" warning, in addition to the current ones and the other doesn't. We need to have the different cases to show that the offset is updated appropriately after the failure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72157/new/

https://reviews.llvm.org/D72157