[PATCH] D72215: [AArch64] Add function attribute "patchable-function-entry" to add NOPs at function entry

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 237248.
MaskRay added a comment.

@peter.smith @ostannard PTAL.

Support -no-integrated-as

  Unfortunately as of binutils 2.33, GNU as does not support the "o" flag (SHF_LINK_ORDER).

Switch from PC-relative relocation to symbolic relocation

  R_MIPS_PC64 does not exist, so I don't dislike -fpatchable-function-entry= that much now.
  If GCC/Linux devs want to add -fpatchable-function-entry=2,0,pcrel , we can follow, and it should be straightforward to implement that.

---

I believe Linux's -fpatchable-function-entry=2 Makefile is not clang friendly.
It does not add this option automatically.

But anyhow, applying D72222 <https://reviews.llvm.org/D72222> and all its depedencies does not break defconfig or allyesconfig.
So this patch series should be safe to merge.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72215/new/

https://reviews.llvm.org/D72215

Files:
  llvm/include/llvm/CodeGen/AsmPrinter.h
  llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  llvm/lib/CodeGen/PatchableFunction.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp
  llvm/test/CodeGen/AArch64/patchable-function-entry.ll
  llvm/test/Verifier/invalid-patchable-function-entry.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72215.237248.patch
Type: text/x-patch
Size: 8775 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200110/eb3fb90a/attachment.bin>