[PATCH] D72490: Fix cmake for zlib

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 22:37:29 PST 2020


wenlei added a comment.

In D72490#1813569 <https://reviews.llvm.org/D72490#1813569>, @mgorny wrote:

> Is there a way to get the basename from ZLIB_LIBRARY by any chance? Not saying it's actually necessary, just wondering.


That would be trying to recover `z` from `a/b/c/libz.so`. Given how `system_libs` is set for other libs (line 8), I think it's better to just set it directly.

I should also mention that the problem was introduced in this change: https://github.com/llvm/llvm-project/commit/abb00753069554c538f3d850897373d093389945#diff-cb177ae2458d3cc8a8e499510ab787c2


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72490/new/

https://reviews.llvm.org/D72490





More information about the llvm-commits mailing list