[PATCH] D72386: [ThinLTO] pass UnrollLoops/VectorizeLoop/VectorizeSLP in CGOpts down to pass builder in ltobackend

[Wei Mi via Phabricator via llvm-commits]

wmi marked 2 inline comments as done.
wmi added a comment.

Thanks for the review!



================
Comment at: clang/test/CodeGen/thinlto-slp-vectorize-pm.c:11
+// ensure the slp vectorization is executed because the -vectorize-slp cc1
+// flag is passed down, not because "-mllvm -vectorize-slp" is enabled.
+//
----------------
tejohnson wrote:
> maybe add "by default" to the end of the last sentence for clarity? Ditto elsewhere.
Done.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1905
 
+    // This is consistent with old pass manager, but inconsistent with
+    // clang. Clang doesn't enable loop vectorization but does enable
----------------
tejohnson wrote:
> Do you mean "consistent with old pass manager invoked via opt"? It currently reads a little confusing, because the old PM is also invoked via clang.
Fixed.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72386/new/

https://reviews.llvm.org/D72386