[PATCH] D70718: [AIX] Replace ExternalSymbolSDNode with a MCSymbolSDNode for memcpy/memset/memmove

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

The test needs some minor changes that can be fixed on the commit. LGTM otherwise.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll:6
+
+; RUN: llvm-readobj --expand-relocs %t.o | FileCheck --check-prefix=32-REL %s
+
----------------
You need `--relocs` in addition to `--expand-relocs`.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-user-defined-memcpy.ll:54
+
+; 32-REL-NOT: Relocation
+
----------------
This needs a comment explaining that we are expecting to have the test fail when the support for relocations land. This would need to be `Relocation{{[[:space:]]}}` to avoid matching on `Relocations`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70718/new/

https://reviews.llvm.org/D70718