[PATCH] D72490: Fix cmake for zlib

[Wenlei He via Phabricator via llvm-commits]

wenlei created this revision.
wenlei added reviewers: twoh, modocache.
Herald added subscribers: llvm-commits, hiraditya, mgorny.
Herald added a project: LLVM.
wenlei added a reviewer: compnerd.

`system_libs` should be set to library names instead of library path. `find_package(ZLIB)` populates `ZLIB_LIBRARY` with path and that evetually gets rolled into `INTERFACE_LINK_LIBRARIES` of LLVMSupport which made it not portable.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72490

Files:
  llvm/lib/Support/CMakeLists.txt


Index: llvm/lib/Support/CMakeLists.txt
===================================================================
--- llvm/lib/Support/CMakeLists.txt
+++ llvm/lib/Support/CMakeLists.txt
@@ -1,5 +1,5 @@
 if(LLVM_ENABLE_ZLIB)
-  set(system_libs ${ZLIB_LIBRARY})
+  set(system_libs z)
 endif()
 
 if( MSVC OR MINGW )


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72490.237232.patch
Type: text/x-patch
Size: 307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200110/d70baa4b/attachment.bin>