[PATCH] D72467: [WIP] Remove "mask" operand from shufflevector.

[Chris Lattner via Phabricator via llvm-commits]

lattner added a comment.

> The big question here, of course, is "do we want to do this?", and if we do, "do we want to do this now?".

Speaking for myself, "yes" and "sooner is better, we should have done this years ago" :-)

Thank you for pushing on this!



================
Comment at: llvm/include/llvm/Analysis/ConstantFolding.h:125
 Constant *ConstantFoldShuffleVectorInstruction(Constant *V1, Constant *V2,
-                                               Constant *Mask);
+                                               ArrayRef<int> Mask);
 
----------------
Please update the comment to indicate what non-positive values are allowed etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72467/new/

https://reviews.llvm.org/D72467