[PATCH] D70698: [CodeGen] Fix hashing for RegMask operands.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 15:15:24 PST 2020


arsenm added a comment.

In D70698#1767973 <https://reviews.llvm.org/D70698#1767973>, @efriedma wrote:

> > The typical case is a tablgenerated target constant, which will be a unique address.
>
> Are tablegen'ed constants guaranteed to be unique, or does it depend on the way each target writes its TableGen files?


I don't think these will be value unique. The dynamic RegMask case used for IPRA throws this away

> 
> 
>> (although I suppose it could)
> 
> Do you think this is worth doing?

Might as well fix it, but I doubt it's possible to really break anything with this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70698/new/

https://reviews.llvm.org/D70698





More information about the llvm-commits mailing list