[PATCH] D72309: Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 15:06:11 PST 2020
arichardson accepted this revision.
arichardson added a comment.
This revision is now accepted and ready to land.
In D72309#1813019 <https://reviews.llvm.org/D72309#1813019>, @arichardson wrote:
> Could we an overload that takes `LLT` instead and keep the boolean flag internal to the .cpp?
Never mind, I saw now that LLT doesn't store int/float information. Seems fine to me but I either would either use isFloat or adjust the name of the boolean to isIntegerLike. Ideally also add a comment that pointers should use the integer variant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72309/new/
https://reviews.llvm.org/D72309
More information about the llvm-commits
mailing list