[llvm] ac53a5f - GlobalISel: Fix else after return

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 14:38:24 PST 2020


Author: Matt Arsenault
Date: 2020-01-09T17:37:52-05:00
New Revision: ac53a5f1dc21916f1072031703e0e1833e963454

URL: https://github.com/llvm/llvm-project/commit/ac53a5f1dc21916f1072031703e0e1833e963454
DIFF: https://github.com/llvm/llvm-project/commit/ac53a5f1dc21916f1072031703e0e1833e963454.diff

LOG: GlobalISel: Fix else after return

Added: 
    

Modified: 
    llvm/lib/CodeGen/LowLevelType.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/LowLevelType.cpp b/llvm/lib/CodeGen/LowLevelType.cpp
index d4baf56635e8..40dfa696a2b9 100644
--- a/llvm/lib/CodeGen/LowLevelType.cpp
+++ b/llvm/lib/CodeGen/LowLevelType.cpp
@@ -24,15 +24,21 @@ LLT llvm::getLLTForType(Type &Ty, const DataLayout &DL) {
     if (NumElements == 1)
       return ScalarTy;
     return LLT::vector(NumElements, ScalarTy);
-  } else if (auto PTy = dyn_cast<PointerType>(&Ty)) {
-    return LLT::pointer(PTy->getAddressSpace(), DL.getTypeSizeInBits(&Ty));
-  } else if (Ty.isSized()) {
+  }
+
+  if (auto PTy = dyn_cast<PointerType>(&Ty)) {
+    unsigned AddrSpace = PTy->getAddressSpace();
+    return LLT::pointer(AddrSpace, DL.getPointerSizeInBits(AddrSpace));
+  }
+
+  if (Ty.isSized()) {
     // Aggregates are no 
diff erent from real scalars as far as GlobalISel is
     // concerned.
     auto SizeInBits = DL.getTypeSizeInBits(&Ty);
     assert(SizeInBits != 0 && "invalid zero-sized type");
     return LLT::scalar(SizeInBits);
   }
+
   return LLT();
 }
 


        


More information about the llvm-commits mailing list