[PATCH] D72327: Fix compiler extension builds

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 13:51:07 PST 2020


Meinersbur added a comment.

It would be nicer if you would commit (and upload for review) the three changes separately. You might just commit the first two changes since I think they are ok, but I am not sure about the `ensureValid` change, which needs some expertise from someone knowing `sys::DynamicLibrary` and `llvm::ManagedStatic`.



================
Comment at: llvm/lib/Support/DynamicLibrary.cpp:152
+
+
 DynamicLibrary DynamicLibrary::getPermanentLibrary(const char *FileName,
----------------
[nit] clang-format would collapse double empty lines into one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72327/new/

https://reviews.llvm.org/D72327





More information about the llvm-commits mailing list