[PATCH] D72214: [GlobalOpt] Get DT only if it is available.

[Ehud Katz via Phabricator via llvm-commits]

ekatz added a comment.

This is a welcoming improvement!
Is it sufficient that I'll approve it for you? Or are you waiting for the code-owner?

Other than that, I know that that it is a bit out of scope of this patch, but can we tag DT analysis as //preserved//?



================
Comment at: llvm/lib/Transforms/IPO/GlobalOpt.cpp:114
+  function_ref<BlockFrequencyInfo &(Function &)> GetBFI;
+  function_ref<DominatorTree &(Function &)> GetDT_;
+  function_ref<DominatorTree *(Function &)> GetDTIfAvailable_;
----------------
Why the underscore? I think this is what clang-tidy warns about.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72214/new/

https://reviews.llvm.org/D72214