[PATCH] D72468: Update the attribution policy to use the 'Author' property of a git commit

Thu Jan 9 13:13:58 PST 2020

dsanders marked an inline comment as done.
dsanders added inline comments.

================
Comment at: llvm/docs/DeveloperPolicy.rst:299
+  set to the original author and the 'Committer' property is set to yourself.
+  You can use ``git commit --amend --author="name/nickname <email>`` to
+  correct the author property if it is incorrect. See `Attribution of Changes`_
----------------
echristo wrote:
> aaron.ballman wrote:
> > It would be helpful if we documented somewhere that the patch author should provide this information as part of their review when deciding who will commit the patch.
> That and if you wouldn't mind a couple of actual command line examples would be nice too.
> It would be helpful if we documented somewhere that the patch author should provide this information as part of their review when deciding who will commit the patch.

Sure. I'm pretty sure I've seen a suitable place but I'm having trouble finding it at the moment. I'll keep looking

> That and if you wouldn't mind a couple of actual command line examples would be nice too.

For this, I've just changed the current command to a realistic example. Hopefully jdoe at llvm.org isn't an address that's in use.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72468/new/

https://reviews.llvm.org/D72468