[PATCH] D72468: Update the attribution policy to use the 'Author' property of a git commit
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 11:11:16 PST 2020
aaron.ballman added a comment.
Thank you for working on this!
================
Comment at: llvm/docs/DeveloperPolicy.rst:295
-* Separate the commit message into title, body and, if you're not the original
- author, a "Patch by" attribution line (see below).
+* Separate the commit message into title, body.
+
----------------
title, body -> a title and a body.
================
Comment at: llvm/docs/DeveloperPolicy.rst:299
+ set to the original author and the 'Committer' property is set to yourself.
+ You can use ``git commit --amend --author="name/nickname <email>`` to
+ correct the author property if it is incorrect. See `Attribution of Changes`_
----------------
It would be helpful if we documented somewhere that the patch author should provide this information as part of their review when deciding who will commit the patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72468/new/
https://reviews.llvm.org/D72468
More information about the llvm-commits
mailing list