[PATCH] D72397: [mlir] m_Constant()

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 10:33:23 PST 2020


rriddle accepted this revision.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/IR/Matchers.h:73
+          if (!bind_value)
+            return true;
+          *bind_value = attrT;
----------------
Avoid the double return here:

if (bind_value)
  *bind_value = attrT;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72397/new/

https://reviews.llvm.org/D72397





More information about the llvm-commits mailing list