[PATCH] D72183: [ELF][PPC64] Add --lax-call-lacks-nop

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 09:56:06 PST 2020


sfertile added a comment.

Thanks for doing this. I think this approach in much safer at the cost of some friction on the systems where the option is needed. My one suggestion would be to separate the tail call case `b foo` from the normal call case. It will cause a runtime failure if the callers caller resides outside the dso and would be much more likely then a failure like glibc encountered. I believe gcc/gfortran got that case correct so it shouldn't impact usability on the older OS releases, but I'm not 100% sure of that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72183/new/

https://reviews.llvm.org/D72183





More information about the llvm-commits mailing list