[PATCH] D71786: RFC: [Support] On Windows, add optional support for rpmalloc

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 09:27:06 PST 2020


aganea added a comment.

In D71786#1812388 <https://reviews.llvm.org/D71786#1812388>, @riccibruno wrote:

> Am I the only one who is a little bit uncomfortable with including a replacement to the system allocator in LLVM? It seems to me that this is something that is clearly under the responsibility of the C library. Now this might still be worth doing given the large performance improvement, but yuck...


Well I think that should give consistent performance across systems. We could (maybe) do like `LD_PRELOAD` with Detours <https://github.com/microsoft/Detours>, but that's less plug'n'play, not sure what @maniccoder thinks? But I'm open to other alternatives.
The other thing to keep in mind is that we (professional game developers) are using LLVM toolchains provided by 1st-partys like Sony or Nintendo, and //we have to// ship our game with their toolchain. The rationale for pushing all these optimizations upstream is for them to eventually get them, and possibly use them easily at some point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71786/new/

https://reviews.llvm.org/D71786





More information about the llvm-commits mailing list