[PATCH] D71128: [NVPTX][FIX] Expand atomics we cannot handle natively in the ISA
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 9 08:40:20 PST 2020
jdoerfert marked an inline comment as done.
jdoerfert added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:1856-1871
+
+ /// See shouldTransformToIntegerOperation(Instruction *)
+ virtual bool shouldTransformToIntegerOperation(LoadInst *LI) const {
+ return shouldTransformToIntegerOperation(cast<Instruction>(LI));
+ }
+
+ /// See shouldTransformToIntegerOperation(Instruction *)
----------------
arsenm wrote:
> Do we really need 4 of these when just the one for Instruction will work
Alternatively we can overload the instruction one and check for the kind to decide what to do. I don't remember how I ended up like this, I'll address this once I get around to this patch again...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71128/new/
https://reviews.llvm.org/D71128
More information about the llvm-commits
mailing list