[PATCH] D72369: DWARFDebugLine.cpp: Format NULL as "(null)" to avoid UB

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 9 07:15:26 PST 2020


jhenderson added a comment.

I'd still really like to see a test that tests the other code path that tries to print DW_LNS_* (see the inline comment). The obvious thing to me to do would be to update the unit test "ParserPrintsStandardOpcodesWhenRequested", but it would require changes to the DwarfGenerator to create a custom prologue. If you don't want to do this, that's okay, as the code path is already untested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72369/new/

https://reviews.llvm.org/D72369





More information about the llvm-commits mailing list