[PATCH] D70286: Merge memtag instructions with adjacent stack slots.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:460
+  } else if (MI.getOpcode() == AArch64::STZGloop_untied) {
+    MI.setDesc(TII->get(AArch64::STZGloop));
+    return MI.getOperand(1).getReg();
----------------
Based on the name of the function, I wouldn't expect this to modify the instruction passed in. I think it would be better to hoist this code out to the call-site, or rename the function to something like `createScratchRegisterForInstruction`, and note that it might do this in a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70286/new/

https://reviews.llvm.org/D70286