[PATCH] D72400: [MLIR] Add OpenMP dialect with barrier operation

[David Truby via Phabricator via llvm-commits]

DavidTruby marked 8 inline comments as done.
DavidTruby added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h:7
+#include "mlir/IR/FunctionSupport.h"
+#include "mlir/IR/OpImplementation.h"
+
----------------
rriddle wrote:
> Is OpImplementation.h necessary here?
I moved this include to the .cpp file. If I don't have it at all I get linker errors related to some missing function definitions.


================
Comment at: mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp:19
+
+static DialectRegistration<OpenMPDialect> openmpDialect;
+
----------------
rriddle wrote:
> jdoerfert wrote:
> > rriddle wrote:
> > > nit: openMPDialect?
> > If we spell out OpenMP it should be `OpenMP`.
> MLIR uses `camelCase` variable names.
I've changed this to ompDialect to be consistent with the namespace name change. Let me know if there's a preferred name for this though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72400/new/

https://reviews.llvm.org/D72400