[PATCH] D72321: Add test for GDB pretty printers.

[Christian Sigg via Phabricator via llvm-commits]

csigg added a comment.



> 1. What do you think about putting this into an `llvm` subdirectory, to make clear that this is a test of llvm/utils rather than generic debug info as all the other tests?

Do you mean something like `debuginfo-tests/llvm-prettyprinters/`? Or 'llvm/tests/prettyprinter'?

> 2. We are gradually moving away from test_debuginfo.pl in favor of dexter. Have you looked at whether this could be implemented using dexter?

I didn't look any further when I saw that dexter doesn't support GDB (according to the readme). 
Not sure if we need to use a debugger abstraction because the pretty printers aren't standardized and therefore the tests will be pretty debugger specific.
If you would like to move away from test_debuginfo.pl, maybe I should split the C++ code and gdb commands+CHECKS into two different files manually. It's not perfect FileCheck methodology, but for a single test in a subdirectory it should be manageable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72321/new/

https://reviews.llvm.org/D72321