[PATCH] D72388: [InstCombine] Adding testcase for Z / (1.0 / Y) => (Y * Z)

Raghesh Aloor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 8 23:12:05 PST 2020


raghesh marked an inline comment as done.
raghesh added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/fdiv.ll:200
+  %div1 = fdiv float 1.0, %y
+  %div2 = fdiv fast float %z, %div1
+  call void @use_f32(float %div1)
----------------
spatel wrote:
> I overlooked this earlier, but you probably want to change this from 'fast' to whatever the minimal flags are. It's fine to do that in the other patch/review if you want.
> 
> 'arcp reassoc'?
Changed 'fast' to 'arc reassoc' by creating a new revision https://reviews.llvm.org/D72431


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72388/new/

https://reviews.llvm.org/D72388





More information about the llvm-commits mailing list