[PATCH] D71828: [InstCombine] Convert vector store to scalar store if only one element updated

Wed Jan 8 07:59:47 PST 2020

qiucf marked an inline comment as done.
qiucf added a comment.

The merge check bot should have some problems in resolving parent-child revision with some already committed. Currently, they have no problem applying into master and tests are passed.

================
Comment at: llvm/test/Transforms/InstCombine/load-insert-store.ll:7
 ; CHECK-NEXT:  entry:
-; CHECK-NEXT:    [[TMP0:%.*]] = load <16 x i8>, <16 x i8>* [[Q:%.*]], align 16
-; CHECK-NEXT:    [[VECINS:%.*]] = insertelement <16 x i8> [[TMP0]], i8 [[S:%.*]], i32 3
-; CHECK-NEXT:    store <16 x i8> [[VECINS]], <16 x i8>* [[Q]], align 16
+; CHECK-NEXT:    [[TMP0:%.*]] = getelementptr <16 x i8>, <16 x i8>* [[Q:%.*]], i64 0, i64 3
+; CHECK-NEXT:    store i8 [[S:%.*]], i8* [[TMP0]], align 1
----------------
spatel wrote:
> Need to regenerate the CHECK lines? All tests should have 'inbounds' on the GEP, right?
Sure. In some cases `inbounds` might be simplified, now we have them :-)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71828/new/

https://reviews.llvm.org/D71828