[PATCH] D72429: [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types.

Wed Jan 8 20:14:56 PST 2020

bondhugula added a comment.

How about just using a space after the keyword instead of angular brackets? The angular bracket right before/after the parenthesis looks a bit clumsy, and there is no specialization being implied on the map/set. It's a character less with the space FWIW. And we could drop affine_ as well - those are the only maps and sets, and it prevents repetition at several places (like affine.apply affine_map, affine.if affine_set ...,  affine.for %i = affine_map...).

With the space and affine_ dropped:

affine.for %j = 0 to map (d0) -> (d0 - d0 mod 4) (%i)

#map1 = map (d0, d1) -> ((d0 * 2048 + d1 * 256) floordiv 32)

memref<512 x 512 x i32, map (d0, d1) -> (d0, d1), 2>

affine.if set (d0, d1) : ...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72429/new/

https://reviews.llvm.org/D72429