[PATCH] D72317: [mlir][VectorOps] Implement insert_strided_slice conversion

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache accepted this revision.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:112
+// Helper that returns a subset of `arrayAttr` as a vector of int64_t.
+static SmallVector<int64_t, 4> getI64SubArray(ArrayAttr arrayAttr,
+                                              unsigned dropFront = 1,
----------------
andydavis1 wrote:
> I think I have a helper function like this in VectorOps.cpp  Need to unify these at some point.
Great, I also have something similar for SmallVector<AffineMap, 4> somewhere else that I need to unify too in a followup commit.
I'll address both and others that I see in a followup.


================
Comment at: mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp:112
+// Helper that returns a subset of `arrayAttr` as a vector of int64_t.
+static SmallVector<int64_t, 4> getI64SubArray(ArrayAttr arrayAttr,
+                                              unsigned dropFront = 1,
----------------
nicolasvasilache wrote:
> andydavis1 wrote:
> > I think I have a helper function like this in VectorOps.cpp  Need to unify these at some point.
> Great, I also have something similar for SmallVector<AffineMap, 4> somewhere else that I need to unify too in a followup commit.
> I'll address both and others that I see in a followup.
Ack, talked a bunch about this with @rriddle too and there is a generic range forwarding + slicing semantics way to do this but it is worth a full separate effort.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72317/new/

https://reviews.llvm.org/D72317